-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F3/thermal #179
Merged
Merged
F3/thermal #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can easily generate correctly formatted serialized versions
added vehicles for thermal calibration various other changes
`from_msg_pack` is complaining about getting a string: `OSError: invalid type: string "\"[]\"", expected a sequence`
running `python/fastsim/demos/demo_hev.py` and then ```python import msgpack fsim.SimDrive.from_msg_pack(msgpack.packb(msgpack.loads(sd.to_msg_pack()))) ``` which yields: ``` --------------------------------------------------------------------------- OSError Traceback (most recent call last) Cell In[8], line 1 ----> 1 fsim.SimDrive.from_msg_pack(msgpack.packb(msgpack.loads(sd.to_msg_pack()))) OSError: invalid type: string "\"[]\"", expected a sequence ```
shows that message pack is 2.5 orders of magnitude faster than yaml!
…ipt/test mode but is hit or miss interactive mode
Evidence that yaml and msg_pack produce darn near the same result on linux machine: ``` in [4]: import deepdiff in [5]: deepdiff.deepdiff? in [6]: deepdiff.deepdiff(sd_dict_msg, sd_dict_yaml) out[6]: {'type_changes': {"root['sim_params.ach_speed_tol']": {'old_type': float, 'new_type': str, 'old_value': 1e-09, 'new_value': '1e-9'}}} in [7]: sd_dict_msg['veh.chassis.wheel_base_meters'] == sd_dict_yaml['veh.chassis.wheel_base_meters'] out[7]: true in [8]: sd_dict_msg['veh.chassis.wheel_base_meters'] out[8]: 2.7 ``` only the one thing changed, and it's not problematic
1 failing test needs to be fixed
This reverts commit 2d42038.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.